Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd.append -> pd.concat #318

Merged
merged 2 commits into from
Oct 7, 2024
Merged

pd.append -> pd.concat #318

merged 2 commits into from
Oct 7, 2024

Conversation

drewnutt
Copy link
Contributor

Problem: Pandas append has been deprecated since version 1.4 and has been removed since version 1.6. create_group_split still uses pandas.append to split the train_val set into the train and val sets.

Solution: Updates create_group_split to utilize pandas.concat to create the train and val sets.

@amva13
Copy link
Member

amva13 commented Oct 2, 2024

hi @drewnutt , we can merge this when it passes the yapf linter. You can do this yourself or I can take care of it at a later time. Thanks for the contribution! Feel fee to tag me if you make the yapf change yourself

@amva13 amva13 self-requested a review October 3, 2024 02:21
@amva13 amva13 merged commit 5fa6557 into mims-harvard:main Oct 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants